Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(host test): Refactor host test CI run #80

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

peter-marcisovsky
Copy link
Collaborator

@peter-marcisovsky peter-marcisovsky commented Oct 25, 2024

Description

This MR removes pytest-ccp from CI run of host tests. A test regression, was observed in #65 when running host tests in CI. The error log was pointing to pytest-cpp and the test failure behavior was unpredictable and could not be reproduces locally.

Related

  • removed usage of pytest-cpp

  • host tests are called directly, by calling .elf files

  • a run_host_tests.sh was added:

    • to simplify adding new host tests (the scrip finds and runs all host tests automatically)
    • to be able to call .elf files with extra arguments, making the tests results more informative
  • For consideration: the run_host_tests.sh can also be omitted and a full path to the .elf file must be provided instead, also the extra arguments for interactive test results must be added to each call

  • Follow-up MR feat(cmock): Enable linux target build for HID, CDC-ACM and UVC hosts #65

Testing

  • it was successfully tested, that if a host test fails, the CI jobs fails as well

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @peter-marcisovsky

@peter-marcisovsky peter-marcisovsky merged commit fbf07ac into master Oct 29, 2024
17 checks passed
@peter-marcisovsky peter-marcisovsky deleted the ci/host_test_refactor branch December 12, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants