-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(esp_tinyusb): Added config option to select USB OTG1.1 periph on P4 #91
Conversation
33e32d5
to
55e82a5
Compare
55e82a5
to
ff842b6
Compare
ff842b6
to
c9736e0
Compare
c9736e0
to
d9c5e8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roma-jam Please add a note to changelog.md and make sure to emphasize that the users need specific commit from esp-idf for this to work. Rest LGTM
@tore-espressif I just revisit the configuration again, and I think that it might need some refactoring.
Which are .... wrong. That is USB Peripheral, not PHY. So I changed it. Also, we are not allowed to select PHY, it is done automatically, that is why I don't think there should a any mentions of "PHY"-word in the TinyUSB config. So I removed all of them and changed them with "Peripheral". Also, I have added the option to enable-disable run-time peripheral port selection to proceed with dynamic configuration and keep the possibility to use the legacy way of port selection (just in case, to verify the hardware, because it is working). |
b0c796c
to
28e9591
Compare
807268c
to
7086e79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thought, otherwise LGTM.
7086e79
to
cf47ab0
Compare
Added a specific point to dep: |
…p32p4 via menuconfig
cf47ab0
to
c219d0c
Compare
Description
Added possibility to select the USB OTG1.1 Peripheral (FS) on ESP32P4 via menuconfig.
Related
N/A
Testing
Could be tested only on correct P4 board.
Limitation
usb_phy_p4.c
in esp-idf. Removing the specific P4-related file additionally unlocks the possibility to initialize PHY for USB OTG1.1, which it necessary for USB OTG1.1 Peripheral.Checklist
Before submitting a Pull Request, please ensure the following: