feat(sccb): new esp sccb component (IEC-92) #309

Icarus113 · 2024-02-22T04:36:08Z

Checklist

Component contains License
Component contains README.md
Component contains idf_component.yml file with url field defined
Component was added to upload job
Component was added to build job
Optional: Component contains unit tests
CI passing

Change description

Please describe your change here

CLAassistant · 2024-02-22T04:36:15Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Icarus113 · 2024-02-22T04:36:44Z

@igrr @suda-morris PTAL

Icarus113 · 2024-02-26T01:36:20Z

@ginkgm PTAL as well

Icarus113 · 2024-02-26T03:47:54Z

@WangYuxin-esp

esp_driver_sccb/CMakeLists.txt

esp_driver_sccb/include/sccb_types.h

esp_driver_sccb/sccb_i2c/include/sccb_i2c.h

esp_driver_sccb/sccb_i2c/src/sccb_i2c.c

suda-morris · 2024-02-26T06:14:12Z

esp_driver_sccb/sccb_i2c/include/sccb_i2c.h

+ *         - ESP_ERR_NO_MEM        If out of memory
+ *         - ESP_OK                On success
+ */
+esp_err_t esp_sccb_new_i2c_ctlr(const esp_sccb_i2c_config_t *config, esp_sccb_handle_t *ret_handle);


question, if the user wants to use the same physical I2C bus for the camera and other i2c slave sensros, how can he do? Because now inside this function, we're allocating the I2C bus, this will take the ownership, and user can't get the same bus outside the sccb driver

I will add a note in the header saying the I2C bus is owned by this API.

how about let the user provide the I2C bus handle, and the sccb driver uses that bus handle?

I think users won't use I2C bus together with SCCB driver

Yes, the classic usage scenario is:

Call i2c_new_master_bus(&i2c_mst_config, &bus_handle) to initialize the I2C bus, obtain the handler, and then use bus_handle to control the sub-device(some sensors, just like led & motor)

Then use the bus_handle to control the camera sensors on the sccb bus.
Maintaining the reusability of this I2C port is an important issue.

esp_driver_sccb/idf_component.yml

esp_driver_sccb/src/sccb.c

suda-morris · 2024-02-27T10:16:16Z

esp_driver_sccb/sccb_i2c/include/sccb_i2c.h

+    uint16_t device_address;              ///< I2C device raw address. (The 7/10 bit address without read/write bit)
+    uint32_t scl_speed_hz;                ///< I2C SCL line frequency
+    i2c_clock_source_t clk_source;        ///< Clock source of I2C master bus, channels in the same group must use the same clock source
+} esp_sccb_i2c_config_t;


does this driver follow bus-device model? If so, what does the sccb represents? If it's a bus driver, I didn't expect there is a device address in the same configuration structure. BTW, device address may reside in a camera sensor's own driver package in case different camera needs special initialization commands.

github-actions bot changed the title ~~feat(sccb): new esp sccb component~~ feat(sccb): new esp sccb component (IEC-92) Feb 22, 2024

Icarus113 force-pushed the feat/esp_sccb_component_new branch 2 times, most recently from 901e384 to 763e82b Compare February 22, 2024 07:00

tom-borcin added the Component: esp_driver_sccb label Feb 22, 2024