Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(freetype): Remove system lib dependencies (IEC-103) #319

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

espressif2022
Copy link
Contributor

@espressif2022 espressif2022 commented Apr 16, 2024

Checklist

  • Component contains License
  • Component contains README.md
  • Component contains idf_component.yml file with url field defined
  • Component was added to upload job
  • Component was added to build job
  • Optional: Component contains unit tests
  • CI passing

Change description

  1. Remove system lib dependencies: If the package required by find_package (such as BrotliDec, HarfBuzz) exists locally on Linux, the local lib will be used, causing compilation failure.
    -- Found BrotliDec: /usr/include (found version "1.0.9")
    -- HarfBuzz (required): /usr/lib/x86_64-linux-gnu/libharfbuzz.so
    /usr/include/stdlib.h:258:25: error: '_Float64x' is not supported on this target

@github-actions github-actions bot changed the title fix(freetype): Remove system lib dependencies fix(freetype): Remove system lib dependencies (IEC-103) Apr 16, 2024
@igrr
Copy link
Member

igrr commented Apr 16, 2024

@espressif2022 Could you please update the description, which issue does the PR fix? Is it a Linux-specific issue? I wonder why we didn't encounter it when this component gets built in CI.

@espressif2022
Copy link
Contributor Author

@espressif2022 Could you please update the description, which issue does the PR fix? Is it a Linux-specific issue? I wonder why we didn't encounter it when this component gets built in CI.

This is related to the system version. For recently installed ubuntu, find_package will find the following system library problems, resulting in failed compilation, check that the package does exist locally.
If it does not exist in the local system, it can be compiled OK. I can't overwrite the option in sub cmake, so I want to ignore the system path here.
-- Found BrotliDec: /usr/include (found version "1.0.9")
-- HarfBuzz (required): /usr/lib/x86_64-linux-gnu/libharfbuzz.so

@igrr
Copy link
Member

igrr commented Apr 18, 2024

I see, thanks for explaining. I can reproduce the issue on macOS as well now, provided I install these libraries. I suppose we will need a more general solution since we can't possibly know all the possible include paths on all the systems.

I'm okay with merging this workaround first, though.

@igrr igrr merged commit 08da3c1 into espressif:master Apr 18, 2024
71 checks passed
@igrr
Copy link
Member

igrr commented Apr 19, 2024

@espressif2022 I've opened #320 as a slightly more future-proof solution to the external dependencies issue.

@espressif2022 espressif2022 deleted the fixed/freetype_cmake branch May 30, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants