Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(libsodium): add more source files to the build list #450

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

mahavirj
Copy link
Member

Checklist

  • CI passing

Change description

Closes #449

Copy link

github-actions bot commented Nov 28, 2024

Test Results

15 files  15 suites   7m 0s ⏱️
11 tests 11 ✅ 0 💤 0 ❌
55 runs  55 ✅ 0 💤 0 ❌

Results for commit b3b60c8.

♻️ This comment has been updated with latest results.

Copy link
Member

@igrr igrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the comment about the test cases.

@mahavirj mahavirj force-pushed the feature/libsodium_build_more_srcs branch from 6e71b67 to b3b60c8 Compare November 29, 2024 13:34
@mahavirj mahavirj merged commit 772c89d into master Nov 29, 2024
49 checks passed
@mahavirj mahavirj deleted the feature/libsodium_build_more_srcs branch November 29, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libsodium component is missing sources from CMakeLists (IEC-239)
2 participants