-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(esp_jpeg): Correctly handle invalid 0xFFFF marker #471
base: master
Are you sure you want to change the base?
Conversation
6349630
to
35bc4a3
Compare
Test Results15 files 15 suites 1m 10s ⏱️ Results for commit c851221. ♻️ This comment has been updated with latest results. |
@peter-marcisovsky This should fix decoding of frames from your camera. @espzav PTAL :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm, this fixes Logitech C170. I will try other camera resolutions to make sure it's working fine. Good catch, thank you for the fix.
35bc4a3
to
c851221
Compare
@peter-marcisovsky @igrr Thank you very much for the reviews! All fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tore-espressif Good work, thank you for this fix. LGTM
Checklist
url
field definedChange description
Please describe your change here