Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esp_jpeg): Correctly handle invalid 0xFFFF marker #471

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tore-espressif
Copy link
Collaborator

@tore-espressif tore-espressif commented Jan 29, 2025

Checklist

  • Component contains License
  • Component contains README.md
  • Component contains idf_component.yml file with url field defined
  • Component was added to upload job
  • Component was added to build job
  • Optional: Component contains unit tests
  • CI passing

Change description

Please describe your change here

@tore-espressif tore-espressif self-assigned this Jan 29, 2025
@tore-espressif tore-espressif force-pushed the fix/esp_jpeg_broken_marker branch from 6349630 to 35bc4a3 Compare January 29, 2025 15:39
Copy link

github-actions bot commented Jan 29, 2025

Test Results

15 files  15 suites   1m 10s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
20 runs  20 ✅ 0 💤 0 ❌

Results for commit c851221.

♻️ This comment has been updated with latest results.

@tore-espressif tore-espressif marked this pull request as ready for review January 29, 2025 21:03
@tore-espressif tore-espressif requested a review from espzav January 30, 2025 06:26
@tore-espressif
Copy link
Collaborator Author

@peter-marcisovsky This should fix decoding of frames from your camera.

@espzav PTAL :)

Copy link
Contributor

@peter-marcisovsky peter-marcisovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm, this fixes Logitech C170. I will try other camera resolutions to make sure it's working fine. Good catch, thank you for the fix.

esp_jpeg/test_apps/main/test_usb_camera_2_jpg.h Outdated Show resolved Hide resolved
@tore-espressif tore-espressif force-pushed the fix/esp_jpeg_broken_marker branch from 35bc4a3 to c851221 Compare January 31, 2025 12:59
@tore-espressif
Copy link
Collaborator Author

@peter-marcisovsky @igrr Thank you very much for the reviews! All fixed

Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tore-espressif Good work, thank you for this fix. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants