Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tested] Add IDF full CLI installation and CI improvement #62

Merged
merged 7 commits into from
Nov 5, 2024

Conversation

Fabricio-ESP
Copy link
Collaborator

Description

This Pull request includes:
-Refactor existing tests to make it modular and easier to expand for future tests.

  • Add test scenario with CLI installation using settings passed as arguments
  • Improve CI to trigger autotests after build workflow. It should be triggered automatically every time the build workflow is triggered.

Related

Testing

Tests were done locally on Linux and Windows machines and manually triggering CI from the branch


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Copy link

Test Results

 6 files  + 6  26 suites  +26   31m 27s ⏱️ + 31m 27s
13 tests +13  13 ✅ +13  0 💤 ±0  0 ❌ ±0 
26 runs  +26  26 ✅ +26  0 💤 ±0  0 ❌ ±0 

Results for commit 5e00c39. ± Comparison against base commit e2fe1f5.

@Fabricio-ESP
Copy link
Collaborator Author

Got verbal approval from Petr to merge the PR.
There is no impact on the EIM code, only on the tests.
Additionally, this PR fixes the test workflow to have tests executed after the build pipeline.

@Fabricio-ESP Fabricio-ESP merged commit 96637fc into master Nov 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant