-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EIM-104] [Test] Automated test refactor #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing is that I would probably unify the three 'runs' and take the json filename as param. because it's just duplicate code, but otherwise it's looking good.
.github/workflows/test.yml
Outdated
reporter: mocha-json | ||
fail-on-empty: "true" | ||
|
||
# publish-test-results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgotten ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
tests/script/installCustom.test.js
Outdated
logger.info("Installation completed"); | ||
testRunner.output = ""; | ||
testRunner.sendInput("n"); | ||
// expect( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgotten?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed my mind about adding a test there. Removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Test automation infrastructure refactor. The actual tests steps are miantained but with this PR starting this tests are concentrated into a ingle test runner script.
The script is launched using different entry codes which will use JSON files as test suite instructions.
The test parameters are defined in the files located at ./src/tests/runs/suites
The tests are launched directly from npm scripts, so the bash/powershell scripts have been removed.
To create new tests runs, with different set of parameters it is only necessary to add a new entry in the json file. Future test suite expansion will use this structure by creating new test types, or appending test cases to the current scripts.
CI
The workflow setup is currently running the "basic" test and "extended" test on all runners. The intent is to split this into different workflows and have the basic tests running for all PRs, and the extended test only focusing on release testing. The exact distinction will be defined later.
Test Reports
For each test runs, reports are published back into the workflow page for easier readability, note the example below.
Known issues
The failing tests are already documented.
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: