Skip to content

Commit

Permalink
Merge pull request #282 from espressif/fix/ide_installer_workflow
Browse files Browse the repository at this point in the history
fix: IDE Installer asset name uploaded on server
  • Loading branch information
jakub-kocka authored Nov 4, 2024
2 parents 0737e55 + 0fabe5f commit 1072b70
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build-espressif-ide-installer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ jobs:
with:
tag_name: espressif-ide-${{ inputs.espressif_ide_version }}-with-esp-idf-${{ inputs.esp_idf_version }}
release_name: Release of Espressif IDE ${{ inputs.espressif_ide_version }} with ESP-IDF ${{ inputs.esp_idf_version }}
draft: true
prerelease: true
draft: false
prerelease: false

- name: Get installer size and store it to file
run: |
Expand All @@ -78,7 +78,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ steps.create_release.outputs.upload_url }}
asset_path: ./build/espressif-ide-setup-espressif-ide-with-esp-idf-${{ inputs.esp_idf_version }}-signed.exe
asset_path: ./build/esp-idf-tools-setup-espressif-ide-${{ inputs.espressif_ide_version }}-with-esp-idf-${{ inputs.esp_idf_version }}-signed.exe
asset_name: esp-idf-tools-setup-espressif-ide-${{ inputs.espressif_ide_version }}-with-esp-idf-${{ inputs.esp_idf_version }}.exe
asset_content_type: application/octet-stream

Expand All @@ -89,4 +89,4 @@ jobs:
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_DEFAULT_REGION: ${{ secrets.AWS_DEFAULT_REGION }}
shell: pwsh
run: aws s3 cp --acl=public-read --no-progress ./build/espressif-ide-setup-espressif-ide-with-esp-idf-${{ inputs.esp_idf_version }}-signed.exe s3://${{ secrets.DL_BUCKET }}/dl/idf-installer/espressif-ide-setup-${{ inputs.espressif_ide_version }}-with-esp-idf-${{ inputs.esp_idf_version }}.exe
run: aws s3 cp --acl=public-read --no-progress ./build/esp-idf-tools-setup-espressif-ide-${{ inputs.espressif_ide_version }}-with-esp-idf-${{ inputs.esp_idf_version }}-signed.exe s3://${{ secrets.DL_BUCKET }}/dl/idf-installer/esp-idf-tools-setup-espressif-ide-${{ inputs.espressif_ide_version }}-with-esp-idf-${{ inputs.esp_idf_version }}.exe
2 changes: 1 addition & 1 deletion src/Resources/download/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ <h2 class="text-center">Open Source IoT Development Framework for ESP32</h2>
</div>

<div class="download-button">
<form method="get" action="https://dl.espressif.com/dl/idf-installer/espressif-ide-setup-3.1.0-with-esp-idf-5.3.1.exe">
<form method="get" action="https://dl.espressif.com/dl/idf-installer/esp-idf-tools-setup-espressif-ide-3.1.0-with-esp-idf-5.3.1.exe">
<button class="button-espressif-ide">
<i class="fa fa-download" aria-hidden="true"></i>
<div>Espressif-IDE 3.1.0 with ESP-IDF v5.3.1 - Offline Installer</div>
Expand Down

0 comments on commit 1072b70

Please sign in to comment.