Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/make idf common functions as mixin #179

Merged
merged 9 commits into from
May 29, 2023
Merged

Refactor/make idf common functions as mixin #179

merged 9 commits into from
May 29, 2023

Conversation

hfudev
Copy link
Member

@hfudev hfudev commented Jan 4, 2023 •
edited
Loading

@hfudev hfudev requested review from igrr and alekseiapa January 4, 2023 09:25
@hfudev hfudev marked this pull request as draft January 4, 2023 09:29
@hfudev hfudev force-pushed the refactor/make_idf_common_functions_as_mixin branch 2 times, most recently from 5fb6a2d to c91c0a9 Compare January 5, 2023 01:52
@espressif espressif deleted a comment from github-actions bot Feb 21, 2023
@hfudev hfudev force-pushed the refactor/make_idf_common_functions_as_mixin branch 3 times, most recently from bb9bfe1 to 3ea5ebd Compare May 5, 2023 07:58
@hfudev hfudev self-assigned this May 5, 2023
@hfudev hfudev marked this pull request as ready for review May 5, 2023 09:02
@hfudev hfudev force-pushed the refactor/make_idf_common_functions_as_mixin branch 3 times, most recently from ac06798 to ed9307e Compare May 11, 2023 06:56
@hfudev
Copy link
Member Author

hfudev commented May 11, 2023 •
edited
Loading

@igrr PTAL the qmp system_reset solution. The reason I'm using unix socket instead of tcp connection is because there will be some TIME_WAIT socket connection left after I close the qmp client. That would somehow occupy the port and make the next test case failed while setup.

@hfudev hfudev force-pushed the refactor/make_idf_common_functions_as_mixin branch from ed9307e to 4a8c80d Compare May 12, 2023 05:34
@igrr
Copy link
Member

igrr commented May 15, 2023

Otherwise LGTM.

@hfudev hfudev force-pushed the refactor/make_idf_common_functions_as_mixin branch from 4a8c80d to 266772a Compare May 22, 2023 08:39
@hfudev hfudev force-pushed the refactor/make_idf_common_functions_as_mixin branch from 266772a to f81c8bf Compare May 22, 2023 08:49
@hfudev
Copy link
Member Author

hfudev commented May 22, 2023

@igrr I've removed the qmp support. it's really unstable.

Lots of exceptions will be thrown while deconstruction.

ERROR    qemu.qmp.protocol:protocol.py:910 Task.Writer: asyncio.exceptions.CancelledError
ERROR    qemu.qmp.protocol:protocol.py:910 Task.Reader: asyncio.exceptions.CancelledError
ERROR    qemu.qmp.protocol:protocol.py:910 Task.Writer: asyncio.exceptions.CancelledError
ERROR    qemu.qmp.protocol:protocol.py:910 Task.Reader: asyncio.exceptions.CancelledError

related issue: https://gitlab.com/qemu-project/python-qemu-qmp/-/issues/6

Shall we merge it for now? IMHO writing a \n for qemu dut hard reset is of course not a correct solution, but a okay solution though...

@hfudev hfudev force-pushed the refactor/make_idf_common_functions_as_mixin branch from f81c8bf to 6b0df9d Compare May 29, 2023 07:40
@hfudev hfudev merged commit cea2ac1 into main May 29, 2023
@hfudev hfudev deleted the refactor/make_idf_common_functions_as_mixin branch May 29, 2023 10:55
@hfudev
Copy link
Member Author

hfudev commented May 31, 2023

also closes #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igrr igrr igrr left review comments

@alekseiapa alekseiapa Awaiting requested review from alekseiapa

Assignees

@hfudev hfudev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[qemu,idf] QemuDut based on Dut even when service idf is enabled (RDT-319)
2 participants
@hfudev @igrr