Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wokwi): Add scenario path parameter #284

Merged
merged 1 commit into from
Apr 29, 2024
Merged

feat(wokwi): Add scenario path parameter #284

merged 1 commit into from
Apr 29, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Apr 29, 2024 •
edited
Loading

This PR adds a support of scenario file for Pytest-wokwi.
To use scenario file add --wokwi-scenario <path> to the pytest command

@P-R-O-C-H-Y
Copy link
Member Author

@hfudev Can you please take a look?

hfudev
hfudev reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. only one question

pytest-embedded-wokwi/pytest_embedded_wokwi/wokwi_cli.py Show resolved Hide resolved
@hfudev
Copy link
Member

hfudev commented Apr 29, 2024 •
edited
Loading

please rebase after #283 got merged. the ci is failing due to the internal api changed in pytest 8.2.

@hfudev
Copy link
Member

hfudev commented Apr 29, 2024

(no need to rebase then, I'll merge this PR when 3.7 test passed since we're currently lack of wokwi test job)

@P-R-O-C-H-Y
Copy link
Member Author

(no need to rebase then, I'll merge this PR when 3.7 test passed since we're currently lack of wokwi test job)

ok Thanks :)

@hfudev hfudev merged commit 1778f7a into espressif:main Apr 29, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfudev hfudev hfudev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@P-R-O-C-H-Y @hfudev