fix: read all chunks in queue since we have interval in listener #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horw
reviewed
Jan 23, 2025
| @@ -42,6 +44,10 @@ def put(self, obj, **kwargs): | |||
| except: # noqa # queue might be closed | |||
| pass | |||
|
|
|||
| def get_all(self) -> List[bytes]: | |||
| with self.lock: | |||
| return [self.get() for _ in range(self.qsize())] | |||
There was a problem hiding this comment.
I have not tried it at Mac, but there is a comment in the code.
def qsize(self):
# Raises NotImplementedError on Mac OSX because of broken sem_getvalue()
return self._maxsize - self._sem._semlock._get_value()
There was a problem hiding this comment.
nice point. i'll use the try except get then
horw
reviewed
Jan 23, 2025
horw
reviewed
Jan 23, 2025
hfudev
force-pushed
the
fix/get-queue-blocked
branch
from
21dfc95 to
748ac58
Compare
|
@hfudev Thank you for looking into this. My original issue still exists, but at least the 100ms sleep effect will be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #334