Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airbyte-to-flow: normalizing dates to date-time must use 00:00:00 #274

Merged
merged 1 commit into from
Oct 25, 2023
Merged

airbyte-to-flow: normalizing dates to date-time must use 00:00:00 #274

merged 1 commit into from
Oct 25, 2023

Conversation

mdibaiee
Copy link
Member

@mdibaiee mdibaiee commented Oct 25, 2023 •
edited
Loading

  • It seems parse_with_timezone assumes the current local time if no time is available when parsing a naive date
  • The change here sets the time to 00:00:00 if no time is given.
  • Tested using our unit tests for this section

jgraettinger
jgraettinger approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdibaiee mdibaiee merged commit 05b4080 into master Oct 25, 2023
56 of 57 checks passed
@mdibaiee mdibaiee deleted the mahdi/datetime-normalization branch October 25, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraettinger jgraettinger jgraettinger approved these changes

@willdonnelly willdonnelly Awaiting requested review from willdonnelly

@psFried psFried Awaiting requested review from psFried

@williamhbaker williamhbaker Awaiting requested review from williamhbaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdibaiee @jgraettinger