airbyte-to-flow: use write_all instead of write for responses #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue that was seen in production where the output of airbyte-to-flow could not be parsed as JSON. The source of the issue seems likely to be that ATF is calling `write` instead of `write_all` when it writes the responses to stdout (the return value of `write` was ignored).
mdibaiee
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that was seen in production where the output of airbyte-to-flow could not be parsed as JSON. The source of the issue seems likely to be that ATF is calling
writeinstead ofwrite_allwhen it writes the responses to stdout (the return value ofwritewas ignored).