This repository has been archived by the owner on Sep 26, 2022. It is now read-only.
Remove opengraph now that UI doesn't depend on it #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,181 +14,170 @@ declare | |||
| connector_id flowid; | |||
| begin | |||
There was a problem hiding this comment.
There appear to be deeper changes here than just updating the associated metadata fields?
In any case perhaps we can just kill this seed_connectors.sql. We have local/install-connector.sh for local development, and it's not a goal that we have source-control for every connector installed in the production DB, so I don't believe it serves a purpose anymore.
| alter view live_specs_ext owner to authenticated; | ||
|
|
||
| -- Extended view of user draft specifications. | ||
| create view draft_specs_ext as |
There was a problem hiding this comment.
Q: what changed about draft_specs_ext, that it must be migrated?
|
|
||
| ALTER TABLE IF EXISTS public.connectors DROP COLUMN IF EXISTS open_graph_patch; | ||
|
|
||
| DROP FUNCTION IF EXISTS public.generate_opengraph_value(opengraph_raw jsonb, opengraph_patch jsonb, field text); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on estuary/ui#319, since otherwise if we merge this the UI will break because it's asking for a field that won't exist
@jgraettinger is it... okay to just nuke all of this opengraph stuff? Is it being used for anything else?
This change is