source-zendesk-support: add logging & ticket_comments checkpoint
#2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Bair
added
the
change:unplanned
Alex-Bair
force-pushed
the
bair/zendesk-support-ticket-comments-checkpoint
branch
from
d873ac5
to
3cf40b4
Compare
For users with a lot of data, the `ticket_comments` stream can take a while to backfill, especially given the 30 requests/60 seconds rate limit for this endpoint. Checkpointing that stream will help if that backfill complete over connector restarts, and it'll provide an indicator in the UI that the connector is still processing records. I've also added logging to catch if the `ticket_comments` cursor does not increase & to log the status codes for non-200 responses to help troubleshoot if the connector is stuck making the same failing request.
Alex-Bair
force-pushed
the
bair/zendesk-support-ticket-comments-checkpoint
branch
from
3cf40b4
to
01e1295
Compare
|
I saw a typo in the logged warning I added, so I fixed that before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For users with a lot of data, the
ticket_commentsstream can take a while to backfill, especially given the 30 requests/60 seconds rate limit for this endpoint. Checkpointing that stream will help if that backfill complete over connector restarts, and it'll provide an indicator in the UI that the connector is still processing records.I've also added logging to catch if the
ticket_commentscursor does not increase & to log the status codes for non-200 responses to help troubleshoot if the connector is stuck making the same failing request.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Tested on a local stack. Confirmed
ticket_commentsis checkpointed every 1,000 documents.This change is