Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-postgres: exclude temp tables from discovery #2133

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

psFried
Copy link
Member

@psFried psFried commented Nov 8, 2024

Filters out temporary and unlogged tables during discovery. These tables cause validation to fail because they cannot be added to publications. The filtering is done based on the pg_class.relpersistence values, described in the docs: https://www.postgresql.org/docs/current/catalog-pg-class.html#CATALOG-PG-CLASS


This change is Reviewable

Filters out temporary and unlogged tables during discovery. These tables cause
validation to fail because they cannot be added to publications. The filtering
is done based on the `pg_class.relpersistence` values, described in the docs:
https://www.postgresql.org/docs/current/catalog-pg-class.html#CATALOG-PG-CLASS
@psFried psFried marked this pull request as ready for review November 8, 2024 20:53
Copy link
Member

@willdonnelly willdonnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psFried psFried merged commit 2e0ec09 into main Nov 11, 2024
52 of 53 checks passed
@psFried psFried deleted the phil/pg-temp-tables branch November 11, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants