Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-front: rewrite as native connector #2150

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

Alex-Bair
Copy link
Contributor

@Alex-Bair Alex-Bair commented Nov 14, 2024

Description:

The source-front connector was not working correctly as an import. Instead of troubleshooting the low-code Airbyte import, I chose to rewrite it as a native connector with only a subset of the streams. I focused on parent streams that seemed most important for the user's use case.

Backwards compatibility with the single existing, broken capture was not a goal.

The version number has been incremented since the connector is changing from an Airbyte import to a native implementation. Last time I rewrote an import as a native connector, I kept the version number the same and ran into issues with the resource path pointers after deployment. Incrementing the version number should avoid the same issue this time.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

Documentation should be created for this connector. I'll link the docs PR here once it's ready.

Notes for reviewers:

Tested on a local stack. Confirmed:

  • all streams capture data & complete.
  • incremental streams checkpoint & log every so often to prove they're making progress.

Some streams (primarily conversations and events can take a while to complete depending on how much data is in the user's Front account.

Snapshot changes are expected due to this being a full connector rewrite.

The capture snapshot does not include any documents from the events stream because I couldn't generate any events in the test Front account I created. It's possible Front only generates events for paying customers, although I couldn't find any documentation to support that theory.


This change is Reviewable

@Alex-Bair Alex-Bair added the change:unplanned Unplanned change, useful for things like doc updates label Nov 14, 2024
@Alex-Bair Alex-Bair force-pushed the bair/source-front-native-implementation branch from 254e9bf to 54d5e5c Compare November 15, 2024 13:18
Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a few minor comments

source-front/source_front/__init__.py Outdated Show resolved Hide resolved
source-front/source_front/api.py Outdated Show resolved Hide resolved
source-front/source_front/api.py Outdated Show resolved Hide resolved
source-front/source_front/api.py Outdated Show resolved Hide resolved
@Alex-Bair Alex-Bair force-pushed the bair/source-front-native-implementation branch from 54d5e5c to 167f019 Compare November 15, 2024 13:43
The `source-front` connector was not working correctly as an import.
Instead of troubleshooting the low-code import, I chose to rewrite it
as a native connector.

Backwards compatibility with the sole existing (non-working) capture was
not a goal. I focused on just parent streams that seemed most important
for the user's use case, and we can add more later as needed.
@Alex-Bair Alex-Bair force-pushed the bair/source-front-native-implementation branch from 167f019 to 14ef6dc Compare November 15, 2024 13:45
@Alex-Bair Alex-Bair merged commit 93efa4e into main Nov 15, 2024
19 of 26 checks passed
@Alex-Bair Alex-Bair deleted the bair/source-front-native-implementation branch November 15, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:unplanned Unplanned change, useful for things like doc updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants