-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc updates for egress IP addresses #1566
Conversation
|
site/docs/concepts/connectors.md
Outdated
@@ -286,7 +288,7 @@ In some cases, your source or destination endpoint may be within a secure networ | |||
to allow direct access to its port due to your organization's security policy. | |||
|
|||
:::tip | |||
If permitted by your organization, a quicker solution is to whitelist the Estuary IP address, `34.121.207.128`. | |||
If permitted by your organization, a quicker solution is to whitelist the Estuary IP addresses, `34.121.207.128, 35.226.75.135, 34.68.62.148`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually kind of tricky. I moved these into a code block for where it's in a tool tip and it looks like the attached.
In other cases, I just added a :
so it was clear a list was coming. Trying to make a UL in markdown for other cases was very visually jarring. The other option was to put something like
34.121.207.128, 35.226.75.135
and 34.68.62.148
for proper English, but the flow on that is gross too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be56166
to
c7fc51a
Compare
committing for preview formatting
c7fc51a
to
3d0c6aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested the main changes on pages with the new IPs (just searched for 35.226.75.135
and hit those pages).
Hit a few other pages that changed due to linting and they all seem to match prod.
Description:
This just updates docs to reflect the three current possible egress IP's for Flow.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
It's all documentation, so every doc in the commit.
This change is