Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics Connector doc updates #1672

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

jwhartley
Copy link
Contributor

@jwhartley jwhartley commented Oct 2, 2024

Description:

Couple updates to google analytics connector docs

Documentation links affected:

Modifying

Notes for reviewers:

  1. I'm new here, open to feedback/correction
  2. I couldn't preview the danger block in github.com preview so not sure it's formatted correctly

This change is Reviewable

- Adding note re deprecation.
- Updating the airbyte docs link - goes to the page not found link, rather than the UA page.

(note their URLs are out of step - https://docs.airbyte.com/integrations/sources/google-analytics-v4/ goes to UA, https://docs.airbyte.com/integrations/sources/google-analytics-universal-analytics is page not found, and https://docs.airbyte.com/integrations/sources/google-analytics-data-api is the GA4 link)

Also note:
1. I'm a newbie, open to feedback/correction here, first time in this markdown and this editor
2. The github.com preview didn't show the danger markdown formatting correctly so I'm not sure it's correct
I noticed the airbyte docs link goes to the archived GA Universal Analytics link, rather than the GA4 page, updating.

(note their URLs are out of step - https://docs.airbyte.com/integrations/sources/google-analytics-v4/ goes to UA, https://docs.airbyte.com/integrations/sources/google-analytics-universal-analytics is page not found, and https://docs.airbyte.com/integrations/sources/google-analytics-data-api is the GA4 link)
@jwhartley
Copy link
Contributor Author

@danthelion could you review?

Copy link
Contributor

@danthelion danthelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwhartley
Copy link
Contributor Author

@danthelion are you also able to approve the workflow and merge? I don't have write-access
image

@dyaffe dyaffe merged commit 2a3deff into estuary:master Nov 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants