Fix flowctl auth ... not properly exchanging access token for refresh token
#1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshearer
force-pushed
the
jshearer/flowctl_auth_fix
branch
from
0577034
to
f955697
Compare
jshearer
changed the title
auth login not properly exchanging access token for refresh tokenauth ... not properly exchanging access token for refresh token
jshearer
changed the title
auth ... not properly exchanging access token for refresh tokenflowctl auth ... not properly exchanging access token for refresh token
jshearer
added
bug
github-actions bot
pushed a commit
to estuary/homebrew-flowctl
that referenced
this pull request
Oct 16, 2024
Fix for `flowctl auth ...` family of commands not properly writing newly minted token estuary/flow#1705 **Full Changelog**: estuary/flow@v0.5.6...v0.5.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This bug was introduced in #1665. I tested the
flowctl authflow as part of that PR, but apparently didn't exercise the branch used when we have an access token, but no refresh token (i.e authenticating for the first time). This fixes that branch by always ensuring the client used to create the refresh token is authenticated, and also makes sure to generate and store a refresh token on theConfigas part of theauthsubcommand.Also tested
auth token, which was similarly broken and is similarly fixed.Fixes #1703
This change is