Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent: add diagnostics for db connections #1717

Merged
merged 1 commit into from
Oct 18, 2024
Merged

agent: add diagnostics for db connections #1717

merged 1 commit into from
Oct 18, 2024
+41 −2

Conversation

psFried
Copy link
Member

@psFried psFried commented Oct 18, 2024 •
edited by jgraettinger
Loading

  • Adds periodic logging of connection pool size
  • Sets the application name to the k8s pod name, to better correlate with pg_stat_activity
  • Sets a connection acquisition timeout
  • Configures logging of slow statements
  • Pings the connection when returning it to the pool, so that we can detect and remove bad connections

This change is Reviewable

@psFried
agent: add diagnostics for db connections
bce14ba 
- Adds periodic logging of connection pool size
- Sets the application name to the k8s pod name, to better correlate
  with pg_stat_activity
- Sets a connection acquisition timeout
- Configures logging of slow statements
- Pings the connection when returning it to the pool, so that we can
  detect and remove bad connections
jshearer
jshearer approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@jshearer jshearer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psFried psFried merged commit 90f68f4 into master Oct 18, 2024
6 checks passed
@psFried psFried added the change:emergency This change is an emergency label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshearer jshearer jshearer approved these changes

Assignees
No one assigned
Labels
change:emergency This change is an emergency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psFried @jshearer