dekaf: Refresh Read's journal client auth token when it expires
#1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #1725. I was still seeing some JWT expired errors, this time they looked like this: ``` WARN serve{...}: dekaf: error=status: Unauthenticated, message: "parsing jwt: token is expired by 12m4.003303197s", details: [], metadata: MetadataMap { headers: {} } ``` After some more digging, I realized that a sufficiently long-lived session containing a sufficiently long-lived `Read` could run into this issue, as the Read's journal client is never refreshed. This fixes that.
|
Closing as the current behavior of closing the connection on token timeout is actually desired, as it surfaces issues wrt connections closing/opening more frequently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a follow-up to #1725. I was still seeing some JWT expired errors, this time they looked like this:
After some more digging, I realized that a sufficiently long-lived session containing a sufficiently long-lived
Readcould run into this issue, as the Read's journal client is never refreshed. This fixes that.Note: I did consider whether it would be cleaner to refactor Read to just take a
flow_client::Clientand wholly manage its own journal client, but it didn't seem better enough to justify the bigger refactor. I'm low conviction on that though, happy to do that refactor if someone else feels more strongly about it.This change is