.github: deployment automation for data-plane-controller and agent-api #1768
Conversation
Introduce workflow_dispatch actions for building and deploying these control-plane services to Cloud Run, using workload identity federation. Include Dockerfile infrastructure and entrypoints for placing secrets into exepected locations. Minor tweaks to data-plane-controller, adjusting defaults to work better with Cloud Run and also to support IPv4 addresses for Ansible hosts, which is required due to our dependency on Cloud Run (which only supports IPv4, paired with Cloud NAT).
| @@ -0,0 +1,31 @@ | |||
| FROM ubuntu:noble | |||
There was a problem hiding this comment.
Does the image here affect our costs in any noticable way? I'm wondering if we could save costs by using a slimmer image. I guess it depends on how frequently this image is going to be run by Cloud Run and how much time is taken by the image to boot up compared to other images 🤔
There was a problem hiding this comment.
Not especially, but this isn't a huge image (50MB iirc?). I do think it's a good idea to use the same OS base as our GitHub runner environment.
| set -o nounset | ||
|
|
||
| # Place secrets into expected file locations. | ||
| mkdir /root/.aws |
There was a problem hiding this comment.
We are not placing anything here, is this actually necessary to create here manually?
There was a problem hiding this comment.
I left it because it's likely we will in the future, if we have agent APIs doing s3 operations (such as for updating storage mappings).
Introduce workflow_dispatch actions for building and deploying these control-plane services to Cloud Run, using workload identity federation.
Include Dockerfile infrastructure and entrypoints for placing secrets into exepected locations.
Minor tweaks to data-plane-controller, adjusting defaults to work better with Cloud Run and also to support IPv4 addresses for Ansible hosts, which is required due to our dependency on Cloud Run (which only supports IPv4, paired with Cloud NAT).
Fixes #1767
(Describe the high level scope of new or changed features)
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is