Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal links open a new tab #556

Closed
Brenosalv opened this issue Nov 1, 2024 · 0 comments · Fixed by #557
Closed

Internal links open a new tab #556

Brenosalv opened this issue Nov 1, 2024 · 0 comments · Fixed by #557
Assignees
@Brenosalv
Labels
tech debt This is a task that really only the engineers notice

Comments

@Brenosalv
Copy link
Collaborator

Bug
Internal links open a new tab.

Expected
Internal links should open a page in the same tab while external ones should keep opening a new tab.
@Brenosalv Brenosalv added the tech debt This is a task that really only the engineers notice label Nov 1, 2024
@Brenosalv Brenosalv self-assigned this Nov 1, 2024
@Brenosalv Brenosalv linked a pull request Nov 1, 2024 that will close this issue
Prevent internal links to open a new tab and make some tweaks #557
Merged
@Brenosalv Brenosalv mentioned this issue Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brenosalv Brenosalv

Labels
tech debt This is a task that really only the engineers notice
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent internal links to open a new tab and make some tweaks estuary/marketing-site
1 participant
@Brenosalv