Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent internal links to open a new tab and make some tweaks #557

Merged
merged 15 commits into from
Nov 4, 2024
Merged

Prevent internal links to open a new tab and make some tweaks #557

merged 15 commits into from
Nov 4, 2024

Conversation

Brenosalv
Copy link
Collaborator

@Brenosalv Brenosalv commented Nov 1, 2024 •
edited
Loading

#556

Changes

  • Make internal links open in the same tab instead of opening a new one;
  • Remove some unnecessary code;
  • Replace component names of the integration page;
  • Fix wrong active users amounts in some pages;
  • Add ending slash to all hrefs.

@Brenosalv Brenosalv added tech debt This is a task that really only the engineers notice content Anything related to content, Strapi, etc. labels Nov 1, 2024
@Brenosalv Brenosalv self-assigned this Nov 1, 2024
@Brenosalv Brenosalv linked an issue Nov 1, 2024 that may be closed by this pull request
Internal links open a new tab #556
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 85603be):

https://estuary-marketing--pr557-brenosalv-tech-debt-cnhi8eap.web.app

(expires Wed, 04 Dec 2024 06:35:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

@Brenosalv Brenosalv marked this pull request as ready for review November 4, 2024 05:23
travjenkins
travjenkins approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - from a coding perspective this is all great.

@travjenkins travjenkins merged commit ffeef66 into master Nov 4, 2024
15 checks passed
@travjenkins travjenkins deleted the Brenosalv/tech-debt/556-internal-links-open-a-new-tab branch November 4, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travjenkins travjenkins travjenkins approved these changes

Assignees

@Brenosalv Brenosalv

Labels
content Anything related to content, Strapi, etc. tech debt This is a task that really only the engineers notice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal links open a new tab
2 participants
@Brenosalv @travjenkins