Create a pricing calculator jump link and add copy button into section #531
Conversation
|
@SourabhEstuary I placed the copy button next to the section title since the link references the section. Do you think it would be better positioned elsewhere in the pricing calculator section? |
|
@SourabhEstuary By the way, the link is: |
|
Visit the preview URL for this PR (updated for commit 5a744c3): https://estuary-marketing--pr531-brenosalv-feature-52-lbts8n08.web.app (expires Sat, 09 Nov 2024 20:34:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e |
|
This looks good |
…to Brenosalv/feature/521-create-a-pricing-calculator-jump-link-for-the-calculator-section-on-the-pricing-page
| <h2 className={title}>PRICING CALCULATOR</h2> | ||
| <div> | ||
| <h2 className={title}>PRICING CALCULATOR</h2> | ||
| <CopyToClipboardButton contentToCopy="https://www.estuary.dev/pricing/#pricing-calculator" /> |
There was a problem hiding this comment.
This content needs updated to use window.location.origin and not be hard coded to the current domain.
| @@ -22,90 +16,50 @@ type ShareArticleProps = { | |||
| }; | |||
|
|
|||
| const ShareArticle = ({ article: { title, slug } }: ShareArticleProps) => { | |||
| const [isCopied, setIsCopied] = React.useState(false); | |||
| const [isCopyFailed, setIsCopyFailed] = React.useState(false); | |||
|
|
|||
| const shareMessage = `Check out the article "${title}"`; | |||
|
|
|||
| const articleUrl = `https://estuary.dev/${slug}`; | |||
There was a problem hiding this comment.
We should make the same change here and use window.location.origin
travjenkins
deleted the
Brenosalv/feature/521-create-a-pricing-calculator-jump-link-for-the-calculator-section-on-the-pricing-page
branch
#521
Changes
Tests / Screenshots