Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the breakpoint for the navbar to expand to full width #537

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Reduce the breakpoint for the navbar to expand to full width #537

merged 1 commit into from
Oct 15, 2024

Conversation

Brenosalv
Copy link
Collaborator

#524

Changes

  • Reduce the breakpoint for the navbar to expand to full width. Old one is 1536px and new one is 1400px.

Tests / Screenshots

image

@Brenosalv Brenosalv added the tech debt This is a task that really only the engineers notice label Oct 15, 2024
@Brenosalv Brenosalv self-assigned this Oct 15, 2024
@Brenosalv Brenosalv linked an issue Oct 15, 2024 that may be closed by this pull request
Adjust Breakpoints for Header #524
Closed
travjenkins
travjenkins approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@travjenkins travjenkins marked this pull request as ready for review October 15, 2024 20:57
@travjenkins travjenkins merged commit 112abbe into master Oct 15, 2024
1 check passed
@travjenkins travjenkins deleted the Brenosalv/tech-debt/524-adjust-breakpoints-for-header branch October 15, 2024 21:07
@github-actions GitHub Actions
Copy link

Visit the preview URL for this PR (updated for commit c54776c):

https://estuary-marketing--pr537-brenosalv-tech-debt-vj8dfzd4.web.app

(expires Thu, 14 Nov 2024 22:07:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travjenkins travjenkins travjenkins approved these changes

Assignees

@Brenosalv Brenosalv

Labels
tech debt This is a task that really only the engineers notice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust Breakpoints for Header
2 participants
@Brenosalv @travjenkins