Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more detail about authors for SEO #550

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

travjenkins
Copy link
Member

Changes

#539

  • Made a reusable SEO JSON generator so Blog and Author page can share logic
  • Minor tweaks to queries

Tests / Screenshots

Blog post now includes full author details

image

Author page shows the same deep details

image

@travjenkins travjenkins marked this pull request as ready for review October 29, 2024 19:54
shared.ts Outdated Show resolved Hide resolved
Brenosalv
Brenosalv previously approved these changes Oct 29, 2024
Copy link
Collaborator

@Brenosalv Brenosalv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - just left two comments for quick fixes.

Copy link

github-actions bot commented Oct 29, 2024

Visit the preview URL for this PR (updated for commit 7e7e5ab):

https://estuary-marketing--pr550-travjenkins-seo-upda-o24a4t1a.web.app

(expires Fri, 29 Nov 2024 20:04:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

@@ -207,113 +207,126 @@ const BlogPostTemplate = ({ data: { post } }) => {
</div>
</section>
) : null}
<section className={nextStepsAndAboutAuthorSection}>
{/* <div className={nextSteps}>
{post?.authors.length >= 1 ? (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this condition to show the author section only if the blog post has at least one author.

It solves this issue:
image

@Brenosalv
Copy link
Collaborator

This build is failing because we have blog post without an author. We just need to set the author to this published blog post: https://strapi.estuary.dev/admin/content-manager/collectionType/api::blog-post.blog-post?page=1&pageSize=10&sort=createdAt:DESC&filters[$and][0][authors][Name][$null]=true

@Brenosalv Brenosalv self-requested a review October 31, 2024 15:45
Copy link
Collaborator

@Brenosalv Brenosalv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@travjenkins travjenkins merged commit ea7c896 into master Oct 31, 2024
15 checks passed
@travjenkins travjenkins deleted the travjenkins/seo/update-author-and-blog-schema branch October 31, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants