-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more detail about authors for SEO #550
Adding more detail about authors for SEO #550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm - just left two comments for quick fixes.
Visit the preview URL for this PR (updated for commit 7e7e5ab): https://estuary-marketing--pr550-travjenkins-seo-upda-o24a4t1a.web.app (expires Fri, 29 Nov 2024 20:04:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e |
@@ -207,113 +207,126 @@ const BlogPostTemplate = ({ data: { post } }) => { | |||
</div> | |||
</section> | |||
) : null} | |||
<section className={nextStepsAndAboutAuthorSection}> | |||
{/* <div className={nextSteps}> | |||
{post?.authors.length >= 1 ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This build is failing because we have blog post without an author. We just need to set the author to this published blog post: https://strapi.estuary.dev/admin/content-manager/collectionType/api::blog-post.blog-post?page=1&pageSize=10&sort=createdAt:DESC&filters[$and][0][authors][Name][$null]=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Changes
#539
Tests / Screenshots
Blog post now includes full author details
Author page shows the same deep details