Add a release banner on top of the homepage #553
Conversation
| <a href={href} target="_blank" rel="noreferrer"> | ||
| <span>A Step Ahead</span> | ||
| <p> | ||
| Explore Estuary's powerful compliance solutions | ||
| - Streamline your security and scale with | ||
| confidence! | ||
| </p> | ||
| <ArrowRight color="#fff" /> | ||
| </a> |
There was a problem hiding this comment.
We should either pass in everything or nothing.
Since the plan it for Dani to submit PRs I think we should just make this a stand alone component that only handles taking in dark or light mode.
Then later on if we need we can make this a base component that takes in an href, title, message, and icon.
There was a problem hiding this comment.
Okay, so we just need the href to be the same for all.
There was a problem hiding this comment.
If in the future we need it to be customizable, we add props to it as you said.
| )} | ||
| > | ||
| <div> | ||
| <a href="/deployment-options" target="_blank" rel="noreferrer"> |
There was a problem hiding this comment.
doubt it matters... but should be end this href with /?
There was a problem hiding this comment.
I wondered the same thing but when we click on the banner, the slash is added automatically. Also, none of the other href have this slash on the end. Anyway, I can ask Sourabh.
|
Visit the preview URL for this PR (updated for commit f0294fa): https://estuary-marketing--pr553-brenosalv-feature-52-pr1su0y1.web.app (expires Sat, 30 Nov 2024 23:29:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e |
travjenkins
deleted the
Brenosalv/feature/525-new-feature-banner-on-main-page
branch
#525
Changes
Tests / Screenshots