Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security page #562

Merged
merged 14 commits into from
Nov 12, 2024
Merged

Security page #562

merged 14 commits into from
Nov 12, 2024

Conversation

Brenosalv
Copy link
Collaborator

#526

Changes

  • Create security page.

@Brenosalv Brenosalv added the enhancement New feature or request label Nov 11, 2024
@Brenosalv Brenosalv self-assigned this Nov 11, 2024
@Brenosalv Brenosalv linked an issue Nov 11, 2024 that may be closed by this pull request
Security page #526
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 39df608):

https://estuary-marketing--pr562-brenosalv-feature-52-g0lu6q2w.web.app

(expires Thu, 12 Dec 2024 19:57:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

@Brenosalv Brenosalv marked this pull request as ready for review November 12, 2024 05:58
travjenkins
travjenkins reviewed Nov 12, 2024
View reviewed changes
src/components/SecurityPage/ExplorePrivateDeployments/index.tsx Outdated
Comment on lines 33 to 35
<OutboundLinkOutlined href={docsPageUrl} target="__blank">
Explore Documentation
</OutboundLinkOutlined>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should link directly to the docs for deployment options: /getting-started/deployment-options/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for sharing the path.

@travjenkins
Copy link
Member

Should we add a link here to the security page
image

Like how we do up above?
image

@Brenosalv
Copy link
Collaborator Author

Should we add a link here to the security page image

Like how we do up above? image

I agree but I'll check with Dani to be sure.

@Brenosalv
Copy link
Collaborator Author

Brenosalv commented Nov 12, 2024 •
edited
Loading

We decided to add a Hubspot form to the security certificates sections.

image

travjenkins
travjenkins approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@travjenkins travjenkins merged commit 479671a into master Nov 12, 2024
15 checks passed
@travjenkins travjenkins deleted the Brenosalv/feature/526-security-page branch November 12, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travjenkins travjenkins travjenkins approved these changes

Assignees

@Brenosalv Brenosalv

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security page
2 participants
@Brenosalv @travjenkins