Skip to content

Commit

Permalink
rename to estuary/vitess
Browse files Browse the repository at this point in the history
  • Loading branch information
@mdibaiee
mdibaiee committed Jul 31, 2024
1 parent 3578998 commit 132c943
Show file tree
Hide file tree
Showing 2,309 changed files with 11,602 additions and 11,602 deletions.
22 changes: 11 additions & 11 deletions Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -178,11 +178,11 @@ demo:
sizegen:
go run ./go/tools/sizegen/sizegen.go \
--in ./go/... \
--gen github.com/mdibaiee/vitess/go/pools/smartconnpool.Setting \
--gen github.com/mdibaiee/vitess/go/vt/schema.DDLStrategySetting \
--gen github.com/mdibaiee/vitess/go/vt/vtgate/engine.Plan \
--gen github.com/mdibaiee/vitess/go/vt/vttablet/tabletserver.TabletPlan \
--gen github.com/mdibaiee/vitess/go/sqltypes.Result
--gen github.com/estuary/vitess/go/pools/smartconnpool.Setting \
--gen github.com/estuary/vitess/go/vt/schema.DDLStrategySetting \
--gen github.com/estuary/vitess/go/vt/vtgate/engine.Plan \
--gen github.com/estuary/vitess/go/vt/vttablet/tabletserver.TabletPlan \
--gen github.com/estuary/vitess/go/sqltypes.Result

# To pass extra flags, run test.go manually.
# For example: go run test.go -docker=false -- --extra-flag
Expand Down Expand Up @@ -216,7 +216,7 @@ e2e_test: build
# Run the code coverage tools, compute aggregate.
unit_test_cover: build dependency_check demo
source build.env
go test $(VT_GO_PARALLEL) -count=1 -failfast -covermode=atomic -coverpkg=github.com/mdibaiee/vitess/go/... -coverprofile=coverage.out ./go/...
go test $(VT_GO_PARALLEL) -count=1 -failfast -covermode=atomic -coverpkg=github.com/estuary/vitess/go/... -coverprofile=coverage.out ./go/...
# Handle go tool cover failures due to not handling `//line` directives, which
# the goyacc compiler adds to the generated parser in sql.go. See:
# https://github.com/golang/go/issues/41222
Expand Down Expand Up @@ -269,12 +269,12 @@ $(PROTO_GO_OUTS): minimaltools install_protoc-gen-go proto/*.proto
--go-grpc_out=. --plugin protoc-gen-go-grpc="${VTROOTBIN}/protoc-gen-go-grpc" \
--go-vtproto_out=. --plugin protoc-gen-go-vtproto="${VTROOTBIN}/protoc-gen-go-vtproto" \
--go-vtproto_opt=features=marshal+unmarshal+size+pool+clone \
--go-vtproto_opt=pool=github.com/mdibaiee/vitess/go/vt/proto/query.Row \
--go-vtproto_opt=pool=github.com/mdibaiee/vitess/go/vt/proto/binlogdata.VStreamRowsResponse \
--go-vtproto_opt=pool=github.com/mdibaiee/vitess/go/vt/proto/binlogdata.VStreamTablesResponse \
--go-vtproto_opt=pool=github.com/estuary/vitess/go/vt/proto/query.Row \
--go-vtproto_opt=pool=github.com/estuary/vitess/go/vt/proto/binlogdata.VStreamRowsResponse \
--go-vtproto_opt=pool=github.com/estuary/vitess/go/vt/proto/binlogdata.VStreamTablesResponse \
-I${PWD}/dist/vt-protoc-21.3/include:proto $(PROTO_SRCS)
cp -Rf github.com/mdibaiee/vitess/go/vt/proto/* go/vt/proto
rm -rf github.com/mdibaiee/vitess/go/vt/proto/
cp -Rf github.com/estuary/vitess/go/vt/proto/* go/vt/proto
rm -rf github.com/estuary/vitess/go/vt/proto/

# Helper targets for building Docker images.
# Please read docker/README.md to understand the different available images.
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[![Maven Central](https://maven-badges.herokuapp.com/maven-central/io.vitess/vitess-jdbc/badge.svg)](https://maven-badges.herokuapp.com/maven-central/io.vitess/vitess-jdbc)
[![Coverage Status](https://codecov.io/gh/vitessio/vitess/branch/main/graph/badge.svg)](https://app.codecov.io/gh/vitessio/vitess/tree/main)
[![Go Report Card](https://goreportcard.com/badge/github.com/mdibaiee/vitess)](https://goreportcard.com/report/github.com/mdibaiee/vitess)
[![Go Report Card](https://goreportcard.com/badge/github.com/estuary/vitess)](https://goreportcard.com/report/github.com/estuary/vitess)
[![FOSSA Status](https://app.fossa.com/api/projects/custom%2B162%2Fvitess.svg?type=shield&issueType=license)](https://app.fossa.com/projects/custom%2B162%2Fvitess?ref=badge_shield&issueType=license)
[![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/1724/badge)](https://bestpractices.coreinfrastructure.org/projects/1724)

Expand Down
2 changes: 1 addition & 1 deletion changelog/16.0/16.0.0/release_notes.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ Here are sample results from a 2020-era Mac M1 with 16 GiB of memory:
$ go test -bench=BenchmarkCompress ./go/vt/mysqlctl -run=NONE -timeout=12h -benchtime=1x -v
goos: darwin
goarch: arm64
pkg: github.com/mdibaiee/vitess/go/vt/mysqlctl
pkg: github.com/estuary/vitess/go/vt/mysqlctl
BenchmarkCompressLz4Builtin
compression_benchmark_test.go:310: downloading data from https://www.dropbox.com/s/raw/smmgifsooy5qytd/enwiki-20080103-pages-articles.ibd.tar.zst
BenchmarkCompressLz4Builtin-8 1 11737493087 ns/op 577.98 MB/s 2.554 compression-ratio
Expand Down
2 changes: 1 addition & 1 deletion changelog/16.0/16.0.0/summary.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ Here are sample results from a 2020-era Mac M1 with 16 GiB of memory:
$ go test -bench=BenchmarkCompress ./go/vt/mysqlctl -run=NONE -timeout=12h -benchtime=1x -v
goos: darwin
goarch: arm64
pkg: github.com/mdibaiee/vitess/go/vt/mysqlctl
pkg: github.com/estuary/vitess/go/vt/mysqlctl
BenchmarkCompressLz4Builtin
compression_benchmark_test.go:310: downloading data from https://www.dropbox.com/s/raw/smmgifsooy5qytd/enwiki-20080103-pages-articles.ibd.tar.zst
BenchmarkCompressLz4Builtin-8 1 11737493087 ns/op 577.98 MB/s 2.554 compression-ratio
Expand Down
4 changes: 2 additions & 2 deletions changelog/17.0/17.0.0/changelog.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@
* Update additional Go dependencies [#12401](https://github.com/vitessio/vitess/pull/12401)
* Fix another mixin dep [#12403](https://github.com/vitessio/vitess/pull/12403)
#### Observability
* Bump github.com/mdibaiee/vitess from 0.15.2 to 0.16.1 in /vitess-mixin [#12875](https://github.com/vitessio/vitess/pull/12875)
* build(deps): bump github.com/mdibaiee/vitess from 0.16.1 to 0.16.2 in /vitess-mixin [#13076](https://github.com/vitessio/vitess/pull/13076)
* Bump github.com/estuary/vitess from 0.15.2 to 0.16.1 in /vitess-mixin [#12875](https://github.com/vitessio/vitess/pull/12875)
* build(deps): bump github.com/estuary/vitess from 0.16.1 to 0.16.2 in /vitess-mixin [#13076](https://github.com/vitessio/vitess/pull/13076)
#### VTAdmin
* Bump dns-packet from 5.3.1 to 5.4.0 in /web/vtadmin [#12545](https://github.com/vitessio/vitess/pull/12545)
* Bump webpack from 5.65.0 to 5.76.1 in /web/vtadmin [#12632](https://github.com/vitessio/vitess/pull/12632)
Expand Down
2 changes: 1 addition & 1 deletion changelog/20.0/20.0.0/changelog.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@
* Upgrade the Golang Dependencies [#15823](https://github.com/vitessio/vitess/pull/15823)
* Upgrade the Golang Dependencies [#15942](https://github.com/vitessio/vitess/pull/15942)
#### Observability
* Bump github.com/mdibaiee/vitess from 0.16.2 to 0.17.7 in /vitess-mixin [#15918](https://github.com/vitessio/vitess/pull/15918)
* Bump github.com/estuary/vitess from 0.16.2 to 0.17.7 in /vitess-mixin [#15918](https://github.com/vitessio/vitess/pull/15918)
* Update `github.com/Azure/go-autorest/autorest/adal` to fix Dependabot alert [#15986](https://github.com/vitessio/vitess/pull/15986)
#### VTAdmin
* Bump vite from 4.5.2 to 4.5.3 in /web/vtadmin [#15634](https://github.com/vitessio/vitess/pull/15634)
Expand Down
4 changes: 2 additions & 2 deletions changelog/20.0/20.0.0/release_notes.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ The following metric names have been changed in VTOrc. The old metrics are still

#### <a id="enum-set-vstream"/>ENUM and SET column handling in VTGate VStream API

The [VTGate VStream API](https://vitess.io/docs/reference/vreplication/vstream/) now returns [`ENUM`](https://dev.mysql.com/doc/refman/en/enum.html) and [`SET`](https://dev.mysql.com/doc/refman/en/set.html) column type values in [`VEvent`](https://pkg.go.dev/github.com/mdibaiee/vitess/go/vt/proto/binlogdata#VEvent) messages (in the embedded [`RowChange`](https://pkg.go.dev/github.com/mdibaiee/vitess/go/vt/proto/binlogdata#RowChange) messages) as their string values instead of the integer based ones — in both the copy/snapshot phase and the streaming phase. This change was done to make the `VStream` API more user-friendly, intuitive, and to align the behavior across both phases. Before [this change](https://github.com/vitessio/vitess/pull/15723) the values for [`ENUM`](https://dev.mysql.com/doc/refman/en/enum.html) and [`SET`](https://dev.mysql.com/doc/refman/en/set.html) columns were string values in the copy phase but integer values (which only have an internal meaning to MySQL) in the streaming phase. This inconsistency led to various [challenges and issues](https://github.com/vitessio/vitess/issues/15750) for each `VStream` client/consumer (e.g. the [`Debezium` Vitess connector](https://debezium.io/documentation/reference/stable/connectors/vitess.html) failed to properly perform a snapshot for tables containing these column types). Now the behavior is intuitive — clients need the string values as the eventual sink is often not MySQL so each consumer needed to perform the mappings themselves — and consistent. While this is a (potentially) breaking change, a new boolean field has been added to the [`FieldEvent`](https://pkg.go.dev/github.com/mdibaiee/vitess/go/vt/proto/binlogdata#FieldEvent) message called `EnumSetStringValues`. When that field is `false` (in Vitess v19 and older) then the consumer will need to perform the mappings during streaming phase, but not during copy phase. When this field is `true`, then no mapping is required. This will help to ensure a smooth transition for all consumers over time. To demonstrate, let's look at the textual output (printing the received `VEvents` as strings) when streaming a single `enum_set_test` table from the unsharded `commerce` keyspace so that we can see what the VStream looks like before and after when we start a new VStream in copy/snapshot mode and then transition to streaming mode for the following table:
The [VTGate VStream API](https://vitess.io/docs/reference/vreplication/vstream/) now returns [`ENUM`](https://dev.mysql.com/doc/refman/en/enum.html) and [`SET`](https://dev.mysql.com/doc/refman/en/set.html) column type values in [`VEvent`](https://pkg.go.dev/github.com/estuary/vitess/go/vt/proto/binlogdata#VEvent) messages (in the embedded [`RowChange`](https://pkg.go.dev/github.com/estuary/vitess/go/vt/proto/binlogdata#RowChange) messages) as their string values instead of the integer based ones — in both the copy/snapshot phase and the streaming phase. This change was done to make the `VStream` API more user-friendly, intuitive, and to align the behavior across both phases. Before [this change](https://github.com/vitessio/vitess/pull/15723) the values for [`ENUM`](https://dev.mysql.com/doc/refman/en/enum.html) and [`SET`](https://dev.mysql.com/doc/refman/en/set.html) columns were string values in the copy phase but integer values (which only have an internal meaning to MySQL) in the streaming phase. This inconsistency led to various [challenges and issues](https://github.com/vitessio/vitess/issues/15750) for each `VStream` client/consumer (e.g. the [`Debezium` Vitess connector](https://debezium.io/documentation/reference/stable/connectors/vitess.html) failed to properly perform a snapshot for tables containing these column types). Now the behavior is intuitive — clients need the string values as the eventual sink is often not MySQL so each consumer needed to perform the mappings themselves — and consistent. While this is a (potentially) breaking change, a new boolean field has been added to the [`FieldEvent`](https://pkg.go.dev/github.com/estuary/vitess/go/vt/proto/binlogdata#FieldEvent) message called `EnumSetStringValues`. When that field is `false` (in Vitess v19 and older) then the consumer will need to perform the mappings during streaming phase, but not during copy phase. When this field is `true`, then no mapping is required. This will help to ensure a smooth transition for all consumers over time. To demonstrate, let's look at the textual output (printing the received `VEvents` as strings) when streaming a single `enum_set_test` table from the unsharded `commerce` keyspace so that we can see what the VStream looks like before and after when we start a new VStream in copy/snapshot mode and then transition to streaming mode for the following table:

```sql
CREATE TABLE `enum_set_test` (
Expand Down Expand Up @@ -175,7 +175,7 @@ An example key difference there being that `after:{lengths:1 lengths:9 lengths:1

If you're using the [`Debezium` Vitess connector](https://debezium.io/documentation/reference/stable/connectors/vitess.html), you should upgrade your connector to 2.7 (the next release) — which should contain [the relevant necessary changes](https://issues.redhat.com/browse/DBZ-7792) — *prior to upgrading Vitess* to v20.0.1 or later. If you're using any of the PlanetScale connectors ([`AirByte`](https://github.com/planetscale/airbyte-source/), [`FiveTran`](https://github.com/planetscale/fivetran-source), or [`singer-tap`](https://github.com/planetscale/singer-tap)) then no actions are required.

If you're using a custom `VStream` client/consumer, then you will need to build a new client with the updated v20 [binlogdata protos](https://pkg.go.dev/github.com/mdibaiee/vitess/go/vt/proto/binlogdata) ([source](https://github.com/vitessio/vitess/blob/main/proto/binlogdata.proto) for which would be in `main` or the `release-20.0` branch) before needing to support Vitess v20.0.1 or later. Your client will then be able to handle old and new messages, with older messages always having this new field set to `false`.
If you're using a custom `VStream` client/consumer, then you will need to build a new client with the updated v20 [binlogdata protos](https://pkg.go.dev/github.com/estuary/vitess/go/vt/proto/binlogdata) ([source](https://github.com/vitessio/vitess/blob/main/proto/binlogdata.proto) for which would be in `main` or the `release-20.0` branch) before needing to support Vitess v20.0.1 or later. Your client will then be able to handle old and new messages, with older messages always having this new field set to `false`.

#### <a id="shutdown-grace-period-default"/>`shutdown_grace_period` Default Change

Expand Down
Loading

0 comments on commit 132c943

Please sign in to comment.