Skip to content

Commit

Permalink
fix(api): delete expset route
Browse files Browse the repository at this point in the history
  • Loading branch information
dtrckd committed Jan 15, 2025
1 parent c5dd903 commit 73efa7b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
4 changes: 2 additions & 2 deletions api/crud.py
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ def update_experimentset(
return db_expset


def remove_db_expset(db: Session, experimentset_id: int) -> bool:
def remove_experimentset(db: Session, experimentset_id: int) -> bool:
db_expset = db.query(models.ExperimentSet).get(experimentset_id)
if db_expset is None:
return False
Expand Down Expand Up @@ -354,7 +354,7 @@ def get_leaderboard(db: Session, metric_name: str = "judge_notator", dataset_nam
.filter(and_(models.Result.experiment_id == result.experiment_id,
models.Result.metric_name != metric_name))\
.all()

entry = schemas.LeaderboardEntry(
experiment_id=result.experiment_id,
model_name=result.model_name,
Expand Down
10 changes: 7 additions & 3 deletions api/endpoints.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,14 @@ def patch_experiment(
return db_exp


@router.delete("/experiment/{id}")
@router.delete(
"/experiment/{id}",
tags=["experiments"],
)
def delete_experiment(
id: int,
db: Session = Depends(get_db),
tags=["experiments"],
admin_check=Depends(admin_only),
):
if not crud.remove_experiment(db, id):
raise HTTPException(status_code=404, detail="Experiment not found")
Expand Down Expand Up @@ -335,11 +338,12 @@ def retry_runs(id: int, db: Session = Depends(get_db)):
# LeaderBoard
#


@router.get("/leaderboard", response_model=schemas.Leaderboard, tags=["leaderboard"])
def read_leaderboard(
metric_name: str = "judge_notator",
dataset_name: str = None,
limit: int = 100,
db: Session = Depends(get_db)
db: Session = Depends(get_db),
):
return crud.get_leaderboard(db, metric_name=metric_name, dataset_name=dataset_name, limit=limit)

0 comments on commit 73efa7b

Please sign in to comment.