Close files on error

etalab · Jan 20, 2025 · 89dad4a · 89dad4a
1 parent d5cd80a
commit 89dad4a
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/apps/transport/lib/registry/gtfs.ex b/apps/transport/lib/registry/gtfs.ex
@@ -74,8 +74,10 @@ defmodule Transport.Registry.GTFS do
       {:ok, unzip} ->
         if has_stops?(unzip) do
           content = unzip |> Unzip.file_stream!("stops.txt")
+          # The zip_file is kept open for now as it's consumed later.
           Result.ok({content, zip_file})
         else
+          Unzip.LocalFile.close(zip_file)
           Result.error("Missing stops.txt in #{archive}")
         end