Skip to content

Commit

Permalink
Remove TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
thbar committed Jan 9, 2024
1 parent 373761c commit 8ba87cd
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions scripts/search_engine.exs
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,6 @@ defmodule SearchIndexer do

def compute_payload(%DB.Dataset{} = dataset) do
# NOTE: not optimized for N+1 because performance is good enough for now
# TODO:
# - pour chaque ressource, trouver la metadata la plus récente
# - pour ça, passer par la resource history la plus récente

modes =
dataset.resources
Expand Down Expand Up @@ -244,7 +241,7 @@ defmodule Searcher do
|> where([d], fragment("search_payload #> Array['formats'] \\? ?", ^search_format))
end

# TODO: DRY
# NOTE: could be DRYed with formats
def maybe_search_resources_modes(query, nil), do: query

def maybe_search_resources_modes(query, mode) do
Expand Down

0 comments on commit 8ba87cd

Please sign in to comment.