Transport.Jobs.Workflow : gérer Oban.TimeoutError #4409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Après le deploy de cette PR je vais supprimer tous les jobs Oban dans la queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4408
Voir le ticket pour la source du problème et les conséquences.
Je n'ai pas réussi à écrire de bons tests en moins de 30 minutes, le challenge est important : dummy Job Oban qui timeout et échanges de messages par le Notifier Oban.
En local j'ai bien reproduit l'erreur, vu la stracktrace qui la causait et vu que c'était correctement géré en exécutant les jobs en local avec le fix présenté ici : encoder la payload, pour gérer le fait qu'on peut avoir une structure ou une chaine de caractères.