Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect to new nodes / disconnect from unused nodes #178

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thirstycrow
Copy link

When slots is updated, RedisCluster should connect to new nodes, and disconnect from the nodes that's not serving data any longer.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 90.406% when pulling cfeab77 on thirstycrow:feature-dynamic-cluster-nodes into 55573df on etaty:master.

redisServerConnections.keys.foreach { server =>
if (!serverSet.contains(server)) {
redisServerConnections.remove(server)
.map(connection => _system.scheduler.scheduleOnce(1.second)(_system.stop(connection.actor)))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the correct way to disconnect from a cluster node? I tried to do it without scheduling, but failed the clusterNodes test

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 90.652% when pulling 4309ccd on thirstycrow:feature-dynamic-cluster-nodes into 55573df on etaty:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 90.652% when pulling dd6bc0c on thirstycrow:feature-dynamic-cluster-nodes into 55573df on etaty:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants