Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-225] Source and target java8 #243

Closed
wants to merge 1 commit into from

Conversation

bluesheeptoken
Copy link

@bluesheeptoken bluesheeptoken commented Jan 21, 2021

Using java13 before the PR:

java -version # `openjdk version "13.0.2" 2020-01-14 `
sbt package
cd target/scala-2.11
unzip rediscala_2.11-1.9.0.jar
javap -verbose redis/util/CRC16.class | grep version # major version: 57

After the PR:

java -version # `openjdk version "13.0.2" 2020-01-14 `
sbt package
cd target/scala-2.11
unzip rediscala_2.11-1.9.0.jar
javap -verbose redis/util/CRC16.class | grep version # major version: 52

It has also been tested in production with our Java 8 backend.

Thanks for the project, we really appreciate it!

Should fix #225

@bluesheeptoken
Copy link
Author

@etaty Sorry for pinging you again for the exact same issue :)

I have made this PR as this is probably the minimal line of code to make sure this is compatible with java8 +.

Let me know if there is anything I can do. Thanks

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 90.386% when pulling c97ed37 on bluesheeptoken:fix-issue-225 into 5600b00 on etaty:master.

@bluesheeptoken bluesheeptoken deleted the fix-issue-225 branch May 21, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnsupportedClassVersionError
3 participants