-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move interface AlarmBackend
from server/etcdserver/api/v3alarm
to server/storage/schema
to fix the unexported-return
lint error
#19342
Conversation
Hi @aladesawe. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Pulled from PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 18 files with indirect coverage changes @@ Coverage Diff @@
## main #19342 +/- ##
==========================================
- Coverage 68.89% 68.86% -0.03%
==========================================
Files 420 420
Lines 35753 35753
==========================================
- Hits 24632 24622 -10
- Misses 9698 9711 +13
+ Partials 1423 1420 -3 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: adeyemi <[email protected]>
1f5aab7
to
6f27da2
Compare
/ok-to-test |
AlarmBackend
from server/etcdserver/api/v3alarm
to server/storage/schema
to fix the unexported-return
lint error
/test pull-etcd-integration-1-cpu-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, aladesawe, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ahrtr Do we need to backport this into v3.6? |
It's YES If this PR was merged after we cut branch release-3.6 but before we release 3.6.0-rc.0. But we have already released the |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.