Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move interface AlarmBackend from server/etcdserver/api/v3alarm to server/storage/schema to fix the unexported-return lint error #19342

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

aladesawe
Copy link
Contributor

@k8s-ci-robot
Copy link

Hi @aladesawe. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aladesawe
Copy link
Contributor Author

Pulled from PR

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.86%. Comparing base (eb7607b) to head (6f27da2).
Report is 4 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/api/v3alarm/alarms.go 84.21% <100.00%> (ø)
server/storage/schema/alarm.go 86.66% <100.00%> (ø)

... and 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19342      +/-   ##
==========================================
- Coverage   68.89%   68.86%   -0.03%     
==========================================
  Files         420      420              
  Lines       35753    35753              
==========================================
- Hits        24632    24622      -10     
- Misses       9698     9711      +13     
+ Partials     1423     1420       -3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7607b...6f27da2. Read the comment docs.

@aladesawe aladesawe force-pushed the server-alarm-unexported-return branch from 1f5aab7 to 6f27da2 Compare February 17, 2025 05:23
@ahrtr
Copy link
Member

ahrtr commented Feb 17, 2025

/ok-to-test

@ahrtr ahrtr changed the title Create an AlarmBackend interface to fix unexported-return Move interface AlarmBackend from server/etcdserver/api/v3alarm to server/storage/schema to fix the unexported-return lint error Feb 17, 2025
@ahrtr
Copy link
Member

ahrtr commented Feb 17, 2025

/test pull-etcd-integration-1-cpu-amd64

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, aladesawe, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit deb9178 into etcd-io:main Feb 18, 2025
42 checks passed
@aladesawe
Copy link
Contributor Author

@ahrtr Do we need to backport this into v3.6?

@ahrtr
Copy link
Member

ahrtr commented Feb 20, 2025

@ahrtr Do we need to backport this into v3.6?

It's YES If this PR was merged after we cut branch release-3.6 but before we release 3.6.0-rc.0.

But we have already released the 3.6.0-rc.0 version, so in generally, no backport. But I don't very strong opinion on that. But definitely no backport after we release 3.6.0-rc.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants