Migrate WALVersion to fix unexported-return of walVersion #19350
Conversation
|
Hi @aladesawe. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Pulled from PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 46 files with indirect coverage changes @@ Coverage Diff @@
## main #19350 +/- ##
==========================================
- Coverage 68.88% 68.84% -0.05%
==========================================
Files 420 420
Lines 35689 35739 +50
==========================================
+ Hits 24585 24605 +20
- Misses 9683 9708 +25
- Partials 1421 1426 +5 Continue to review full report in Codecov by Sentry.
|
|
/ok-to-test |
server/storage/schema/schema.go
Outdated
| // MinimalEtcdVersion returns minimal etcd version able to interpret WAL log. | ||
| MinimalEtcdVersion() *semver.Version | ||
| } | ||
| type WALVersion = wal.Version |
There was a problem hiding this comment.
Let's just remove it and use wal.Version directly.
There was a problem hiding this comment.
Good call, updated
Signed-off-by: adeyemi <[email protected]>
aladesawe
force-pushed
the
server-wal-version-unexported-return
branch
from
47a0e10 to
94758c1
Compare
|
/test pull-etcd-integration-1-cpu-amd64 |
There was a problem hiding this comment.
LGTM. Thanks, @aladesawe.
@ahrtr, can we get this to release-3.6 so we can rename the interface before rc0 is released with this exported (because if we do it later, we'll need to deprecate + rename)?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, aladesawe, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OK. Please feel free to raise a backport PR. |
|
/cherry-pick release-3.6 |
Not sure whether it works or not. cc @ArkaSaha30 @ivanvc |
|
@ahrtr: new pull request created: #19382 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
It works :) |
This fixes WALVersion for issue
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.