migrate experimental-peer-skip-client-san-verification flag to peer-skip-client-san-verification #19362
Conversation
…kip-client-san-verification Co-authored-by: wodeyoulai <[email protected]> Signed-off-by: Siyuan Zhang <[email protected]>
siyuanfoundation
force-pushed
the
lease-checkpoint
branch
from
25e5ca7 to
a3a467b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 20 files with indirect coverage changes @@ Coverage Diff @@
## main #19362 +/- ##
==========================================
+ Coverage 68.84% 68.93% +0.08%
==========================================
Files 420 420
Lines 35729 35739 +10
==========================================
+ Hits 24599 24636 +37
+ Misses 9703 9682 -21
+ Partials 1427 1421 -6 Continue to review full report in Codecov by Sentry.
|
| AutoTLS bool `json:"auto-tls"` | ||
| AllowedCNs []string `json:"allowed-cn"` | ||
| AllowedHostnames []string `json:"allowed-hostname"` | ||
| SkipClientSANVerify bool `json:"skip-client-san-verification,omitempty"` |
There was a problem hiding this comment.
It seems that we didn't support configuring the field from configFile.
There was a problem hiding this comment.
that seems like an oversight? we can configure other experimental flags from configFile.
@serathius
There was a problem hiding this comment.
We might want to partially backport this bug fix to release 3.5 . can you raise an issue to track it ? thx
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To replace #19225
closes #19062
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.