Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a log formatting bug in the e2e downgrade tests #19367

Merged

Conversation

henrybear327
Copy link
Contributor

@henrybear327 henrybear327 commented Feb 9, 2025

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

The log message was of the following format before fixing

cluster_downgrade_test.go:163: Elect members for operations
        %!(EXTRA zapcore.Field={members 1 0  [2 1]})

After

 cluster_downgrade_test.go:163: Elect members for operations zapcore.Field{Key:"members", Type:0x1, Integer:0, String:"", Interface:zap.ints{1}}

@henrybear327 henrybear327 force-pushed the e2e/fix_downgrade_node_election_log branch from b5020c3 to 3bcd2e9 Compare February 9, 2025 22:35
@henrybear327 henrybear327 force-pushed the e2e/fix_downgrade_node_election_log branch from 3bcd2e9 to 9767dbc Compare February 9, 2025 22:36
@henrybear327 henrybear327 self-assigned this Feb 9, 2025
@henrybear327
Copy link
Contributor Author

/retest

@henrybear327 henrybear327 force-pushed the e2e/fix_downgrade_node_election_log branch from 9767dbc to 111aa56 Compare February 9, 2025 22:47
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.85%. Comparing base (9de211d) to head (89dd13f).
Report is 2 commits behind head on main.

Additional details and impacted files

see 29 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19367      +/-   ##
==========================================
- Coverage   68.98%   68.85%   -0.14%     
==========================================
  Files         420      420              
  Lines       35739    35739              
==========================================
- Hits        24656    24609      -47     
- Misses       9660     9702      +42     
- Partials     1423     1428       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de211d...89dd13f. Read the comment docs.

@henrybear327
Copy link
Contributor Author

/retest

tests/e2e/cluster_downgrade_test.go Outdated Show resolved Hide resolved
tests/framework/e2e/downgrade.go Outdated Show resolved Hide resolved
@henrybear327 henrybear327 force-pushed the e2e/fix_downgrade_node_election_log branch 2 times, most recently from 8767398 to b34bf34 Compare February 10, 2025 10:40
@henrybear327 henrybear327 requested a review from ahrtr February 10, 2025 10:40
Signed-off-by: Chun-Hung Tseng <[email protected]>
Co-authored-by: Benjamin Wang <[email protected]>
@henrybear327 henrybear327 force-pushed the e2e/fix_downgrade_node_election_log branch from b34bf34 to 89dd13f Compare February 10, 2025 10:44
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, henrybear327

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 38bb52a into etcd-io:main Feb 10, 2025
38 checks passed
@henrybear327 henrybear327 deleted the e2e/fix_downgrade_node_election_log branch February 10, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants