Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template #137

Closed
wants to merge 30 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
9d893fe
Create github actions for flake8 (#76)
jgphpc Jun 1, 2023
99021f2
Update Eiger configuration after 14.06 maintenance (#88)
lucamar Jun 14, 2023
b5ee4a8
Add cray module for Eiger
Jun 16, 2023
aa03ca2
Add cray module for Eiger in prgenv checks
Jun 16, 2023
894ca7f
Merge pull request #89 from lucamar/fix_cray_module
lucamar Jun 16, 2023
ab03180
Remove aocc environment from hohgant
ekouts Jul 5, 2023
ff41ba5
Merge pull request #92 from ekouts/hohgant_aocc_main
teojgo Jul 5, 2023
9daa9bc
Change the module for singularity on eiger/pilatus
teojgo Aug 16, 2023
ed9d1ee
Merge branch 'main' into pilatus/singularity_3.6.4
teojgo Aug 16, 2023
820f2ef
Merge pull request #97 from teojgo/pilatus/singularity_3.6.4
teojgo Aug 16, 2023
ced485f
Skipping nsimd test (#35)
jgphpc Aug 21, 2023
db6fdcc
Updated Sarus MPI checks using SSH
Madeeks Sep 28, 2023
a163481
Code review changes
Madeeks Sep 28, 2023
a802f40
Merge pull request #125 from Madeeks/update_sarus_ssh_tests
teojgo Oct 2, 2023
1cbd81c
Fix IOR on Alps with capstor
Oct 24, 2023
27253dc
Update checks/system/io/ior_check.py
lucamar Oct 25, 2023
17cb39e
Update checks/system/io/ior_check.py
lucamar Oct 25, 2023
52794a3
Update ior_check.py
lucamar Oct 25, 2023
f7e19d9
Merge pull request #130 from lucamar/fix_ior
teojgo Oct 25, 2023
1768cc2
Update ior_check.py
lucamar Oct 26, 2023
9efa963
Revert to absolute path to avoid syntax error
Oct 26, 2023
da66eb8
Merge branch 'eth-cscs:main' into fix_ior
lucamar Oct 26, 2023
602c42a
Merge branch 'fix_ior' of github.com:lucamar/cscs-reframe-tests into …
Oct 26, 2023
a0f69b8
Merge pull request #131 from lucamar/fix_ior
teojgo Oct 26, 2023
9bfcba2
Update path of respources folder on EIger
Nov 6, 2023
99e9f88
Merge pull request #133 from lucamar/update_resources
teojgo Nov 7, 2023
fda465f
Move some tests to the public repo
teojgo Nov 13, 2023
ec886b4
Disable eiger from the prgenv_check
teojgo Nov 14, 2023
c4a7e66
Merge pull request #134 from teojgo/tests/move_to_public
teojgo Nov 14, 2023
a35f140
Create pull_request_template.yml
jgphpc Nov 29, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/linters/.flake8
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[flake8]
select = F401
43 changes: 43 additions & 0 deletions .github/pull_request_template.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: "Pull request"
description: Add/Update a test
labels: [test]
body:
- type: textarea
id: summary
attributes:
label: Summary
description: Describe the purpose of this pull request.<br>Add a link to the jira issue if it exists.
validations:
required: true
- type: textarea
id: reproduce
attributes:
label: Steps to reproduce
description: |
Share the command line used to run the test, including full path to input files/images and/or environment variables
placeholder: |
```console
$ reframe -r ...

```
validations:
required: true
- type: checkboxes
id: checks
attributes:
label: General information
options:
- label: My pull request originates from a branch in my `fork` of https://github.com/eth-cscs/cscs-reframe-tests
required: true
- label: I split different tests into different pull requests (make the reviewer(s) life easier please)
required: true
- label: My code explicitely mentions the `origin|license|version` of external source code
required: true
- label: I applied `coding conventions` to my code using for example [pycodestyle](https://github.com/PyCQA/pycodestyle) or [black](https://github.com/psf/black)
required: true





Thank you for taking the time to contribute to `cscs-reframe-tests` !
17 changes: 17 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: ReFrame CI

on: [push, pull_request]

jobs:
codechecker:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Lint Code Base
uses: github/super-linter@v4
env:
VALIDATE_ALL_CODEBASE: false
VALIDATE_PYTHON_FLAKE8: true
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion checks/containers/sarus/check_osu_benchmarks.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def generate_ssh_keys(self):
def setup_container_platform(self):
self.container_platform.image = self.sarus_image
self.container_platform.options = [
'--mount=src=/scratch,dst=/scratch,type=bind',
'--mount=src=${SCRATCH:-/scratch},dst=${SCRATCH:-/scratch},type=bind',
'--ssh'
]
self.container_platform.command = (
Expand Down
31 changes: 31 additions & 0 deletions checks/libraries/opengl/opengl_checks.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Copyright 2016-2023 Swiss National Supercomputing Centre (CSCS/ETH Zurich)
# ReFrame Project Developers. See the top-level LICENSE file for details.
#
# SPDX-License-Identifier: BSD-3-Clause

import reframe as rfm
import reframe.utility.sanity as sn


@rfm.simple_test
class TinyEGLTest(rfm.RegressionTest):
descr = 'Test OpenGL without X server'
valid_systems = ['daint:gpu', 'dom:gpu']
valid_prog_environs = ['PrgEnv-gnu']
prerun_cmds = ['unset DISPLAY']
executable = 'tinyegl'
nvidia_path = '/usr/lib64'
build_system = 'Make'
tags = {'production'}

@run_before('compile')
def set_build_system_opts(self):
self.build_system.options = [f'PATH_TO_LIB={self.nvidia_path}']
self.env_vars = {
'LD_LIBRARY_PATH': f'{self.nvidia_path}:$LD_LIBRARY_PATH'}

@sanity_function
def assert_found_pattern(self):
return sn.assert_found(
'0 0 0 0 0 0 76 51 25 76 51 25 76 '
'51 25 76 51 25 76 51 25 0 0 0 0 0 0', self.stdout)
Loading