Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Update the IOR check to fetch source from GitHub #186

Merged
merged 4 commits into from
Apr 17, 2024
Merged

[test] Update the IOR check to fetch source from GitHub #186

merged 4 commits into from
Apr 17, 2024

Conversation

teojgo
Copy link
Collaborator

@teojgo teojgo commented Apr 16, 2024

No description provided.

@teojgo teojgo requested review from jgphpc, lucamar and omlins April 16, 2024 15:02
@teojgo teojgo self-assigned this Apr 16, 2024
lucamar
lucamar approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@lucamar lucamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teojgo

ekouts
ekouts reviewed Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some small comments. Looks fine overall

checks/system/io/ior_check.py Outdated Show resolved Hide resolved
checks/system/io/ior_check.py Outdated Show resolved Hide resolved
teojgo added 2 commits April 16, 2024 17:12
@teojgo
Add the 'cray' module for eiger/pilatus
208d2ac 
Signed-off-by: Theofilos Manitaras <[email protected]>
@teojgo
Address PR comments
b082b38 
Signed-off-by: Theofilos Manitaras <[email protected]>
@teojgo
Copy link
Collaborator Author

teojgo commented Apr 17, 2024

@jenkins-cscs retry all

@teojgo teojgo merged commit a044288 into eth-cscs:main Apr 17, 2024
2 checks passed
@teojgo teojgo deleted the test/ior_check_update branch April 17, 2024 14:19
teojgo added a commit that referenced this pull request Jun 19, 2024
@teojgo
Merge pull request #186 from teojgo/test/ior_check_update
0f253c1 
[test] Update the IOR check to fetch source from GitHub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucamar lucamar lucamar approved these changes

@ekouts ekouts ekouts approved these changes

@jgphpc jgphpc Awaiting requested review from jgphpc

@omlins omlins Awaiting requested review from omlins

Assignees

@teojgo teojgo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teojgo @ekouts @lucamar