Another fake PR for review (do not close!) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nversion to spack package.py
…of markers/returned spec list; improved error handling and code documentation
… actual installable python pkg (flit backend)
…erted to a single package.py
now, prereleases and dev, post, and local versions are not supported and will be excluded.
…ation functions with spack builtins
(adapted from pyproject_metadata).
Reason: raised Exceptions in some cases which lead to the whole file
not being parsed; we want fine grained control over parsing of
fields and handling of errors.
Parse errors for dependenceis & files are displayed to the user in
the output as comments.
davhofer
force-pushed
the
main
branch
2 times, most recently
from
d1ec7e1 to
e3f0716
Compare
…malize package name
* test: setup docker img with spack installation and run installation and import tests in github action * test: separate gh action for pytest and installation tests * chore: rename github actions
- implement GitHubProvider class as alternative to PyPIProvider - currently only supports converting the first, main package from github. All dependencies are resolved through pypi.
…#9) For packages using the scikit-build-core backend (which relies on cmake), extract non-python dependencies and versions from CMakeLists.txt (in a simple/primitive way). Extracted dependencies are added as comments/suggestions to the package.py file. * feat!: add simple parsing and conversion of some fields CMakeLists.txt for scikit-build-core packages. Extracted, proposed dependencies are displayed in the package.py as comments. Renamed PyProjectProvider to PackageProvider. Changed PackageProvider API to support reading contents of arbitrary files in sdist. Moved utilities for interacting with Spack repo/exe to spack_utils.py. * chore: add cmake_parser dependency * chore: remove comments * chore: remove unused import * fix: correct function import * chore: update pyproject.toml for new dependency * fix: cleanup cmake_conversion code * test: fix imports
* test: fix containerized installation tests * test: figure out what goes wrong * test: improve 'run_spack_command' to handle missing spack shell executable
…t' command, display available repos, and ask user for repo by default
…g initial package in spack
* Add docs folder and minimal generation workflow using sphinx with myst-parser and autodoc2 * Add docs related dependencies and configs --------- Co-authored-by: Enrique Gonzalez Paredes <[email protected]>
Collect external (non-python) dependencies for scikit-build-core packages by recursively enumerating all included CMakeLists.txt files and extracting dependencies from them (only for the most recent package version). The dependencies are displayed in the package.py file as comments, grouped together by name and displayed with the respective source CMakeLists file & line number for reference. * fix: recursively traverse subdirectories specified in CMakeLists.txt to get non-python dependencies; only parse CMakeLists for one (most recent) package version * fix: add source information for cmakelists dependencies * fix: collect dependencies on the same non-python package/library from CMakeLists in output and display together * test: add tests for conversion of cmake dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.