Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make environment:mpi:gpu optional #150

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

albestro
Copy link
Contributor

This PR:

  • extends tests with a basic test-case with an environment where mpi:gpu field is not specified
  • fix schema to have a default for the mpi:gpu field (default = null)
  • fix validator to deal with non-existing sections

About this latter point, since I don't have any experience with this library, I'd like to ask you to double check (see comment in the code) if it is the correct reason/solution.

Reference

According to the documentation the mpi:gpu field is optional, but the schema and validator were not supporting that.

stackinator/docs/recipes.md

Lines 141 to 147 in e8219f5

To configure MPI without GPU support, set the `spec` field with an optional version:
```yaml title="environments.yaml: MPI without GPU support"
host-env:
mpi:
spec: [email protected]
# ...
```

stackinator/docs/recipes.md

Lines 149 to 161 in e8219f5

GPU-aware MPI can be configured by setting the optional `gpu` field to specify whether to support `cuda` or `rocm` GPUs:
```yaml title="environments.yaml: GPU aware MPI"
cuda-env:
mpi:
spec: cray-mpich
gpu: cuda
# ...
rocm-env:
mpi:
spec: cray-mpich
gpu: rocm
# ...
```

Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @albestro, this was an error and your solution is sound!

@bcumming bcumming merged commit a70e0a7 into eth-cscs:master Nov 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants