Make literal spack commit available in spack view #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #199, this makes the literal spack commit specified in the recipe available as
UENV_SPACK_COMMIT_LITERAL
in a spack view. However,UENV_SPACK_COMMIT
stays as the commit hash as before.I've now crammed everything into the
--spack
command line argument ofenvvars.py
. Searching around a bit, I think in theory commas are allowed in e.g. branch names, and could therefore end up breaking the parsing (which relies on the repo, literal commit, and commit hash being separated by commas), but it seems like in practice one should not use commas, and I've certainly never seen it in the wild. Just pointing it out in case someone thinks it's worth handling that.I've gone with the name "commit literal" as suggested by @bcumming. I think it fits as it's the "literal" that was used to configure the recipe. I'm not sure if there's a common git term for anything that can be checked out that could be a better option? I considered "reference" since a branch or tag is a reference, but if I understand correctly a commit hash is not a reference (but a commit hash is allowed to be used here), so it doesn't quite fit.Edit: this is now using "ref" and
UENV_SPACK_REF
for what is called "literal" above.With a freshly built stack: