Skip to content

Commit

Permalink
Require at least Node 20 (#478)
Browse files Browse the repository at this point in the history
* Require at least Node 20

* Test all supported node versions
  • Loading branch information
yorickdowne authored Jan 5, 2025
1 parent 805ee0a commit ac5fe46
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/test-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,16 @@ jobs:
test-deploy:
name: Test deployment
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [20, 22]
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: ${{ matrix.node-version }}
cache: npm
cache-dependency-path: './website/package-lock.json'

Expand All @@ -28,3 +31,4 @@ jobs:

- name: Test build website
run: npm run build
continue-on-error: false
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ Below are steps for initialising and reproducing this portal for development.
## Dependencies

1. The latest version of [Node](https://nodejs.org/en/download/) installed.
> You have to be on Node >= 18.x
> You have to be on Node >= 20.x. This is the default version on Ubuntu 24.04 "Noble Numbat" or later,
and Debian 13 "Trixie" or later.

## Installation

Expand Down
2 changes: 1 addition & 1 deletion website/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion website/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
]
},
"engines": {
"node": ">=18.0"
"node": ">=20.0"
}
}

0 comments on commit ac5fe46

Please sign in to comment.