Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use keymanager to register w3s keys with Teku #1530

Merged
merged 1 commit into from
Sep 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions ethd
Original file line number Diff line number Diff line change
Expand Up @@ -1466,8 +1466,8 @@ __i_haz_web3signer() {
fi

var="WEB3SIGNER"
value=$(sed -n -e "s/^${var}=\(.*\)/\1/p" ".env" || true)
if [ ! "${value}" = "true" ]; then
__w3s=$(sed -n -e "s/^${var}=\(.*\)/\1/p" ".env" || true)
if [ ! "${__w3s}" = "true" ]; then
return
fi

Expand Down Expand Up @@ -1571,6 +1571,7 @@ keys() {
fi

__i_haz_web3signer
__command="${1:-}"

__owner_uid=$(id -u "${OWNER}")
if [ "${1:-}" = "import" ]; then
Expand Down Expand Up @@ -1770,6 +1771,20 @@ keys() {
#__i_haz_keys_service
docompose run --rm -e OWNER_UID="${__owner_uid}" validator-keys "$@"
fi
var="COMPOSE_FILE"
value=$(sed -n -e "s/^${var}=\(.*\)/\1/p" ".env" || true)

if [ "${__command}" = "import" ] || [ "${__command}" = "register" ] || [ "${__command}" = "delete" ]; then
# I do mean to match literally
# shellcheck disable=SC2076
if [[ "${__w3s}" = "true" ]] && [[ "${value}" =~ "teku.yml" ]]; then
echo "Sending SIGHUP to Teku to load web3signer keys"
docompose exec consensus kill -SIGHUP 1
elif [[ "${__w3s}" = "true" ]] && [[ "${value}" =~ "teku-vc-only.yml" ]]; then
echo "Sending SIGHUP to Teku to load web3signer keys"
docompose exec validator kill -SIGHUP 1
fi
fi
}

keyimport() {
Expand Down
1 change: 1 addition & 0 deletions teku.yml
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ services:
- KEYSTORE_PASSWORD=${KEYSTORE_PASSWORD:-}
- KEY_API_PORT=${KEY_API_PORT:-7500}
- WEB3SIGNER=${WEB3SIGNER:-false}
- W3S_NOREG=true
- CL_NODE=${CL_NODE}
depends_on:
- consensus
Expand Down
20 changes: 15 additions & 5 deletions vc-utils/keymanager.sh
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,8 @@ validator-delete() {
exit 1
;;
esac
# Remove remote registration
if [ "${WEB3SIGNER}" = "true" ]; then
# Remove remote registration, but not for Teku
if [ -z "${W3S_NOREG+x}" ] && [ "${WEB3SIGNER}" = "true" ]; then
__api_container=${__vc_api_container}
__api_port=${__vc_api_port}
__api_tls=${__vc_api_tls}
Expand Down Expand Up @@ -483,6 +483,8 @@ validator-delete() {
exit 1
;;
esac
else
echo "This client loads web3signer keys at startup, no registration to remove."
fi
done
}
Expand All @@ -494,7 +496,8 @@ validator-import() {

__num_dirs=$(find /validator_keys -maxdepth 1 -type d -name '0x*' | wc -l)
if [ "$__pass" -eq 1 ] && [ "$__num_dirs" -gt 0 ]; then
echo "Found $__num_dirs directories starting with 0x. If these are from eth2-val-tools, please copy the keys and secrets directories into .eth/validator_keys instead."
echo "Found $__num_dirs directories starting with 0x. If these are from eth2-val-tools, please copy the keys \
and secrets directories into .eth/validator_keys instead."
echo
fi

Expand Down Expand Up @@ -705,8 +708,8 @@ validator-import() {
exit 1
;;
esac
# Add remote registration
if [ "${WEB3SIGNER}" = "true" ]; then
# Add remote registration, but not for Teku
if [ -z "${W3S_NOREG+x}" ] && [ "${WEB3SIGNER}" = "true" ]; then
__api_container=${__vc_api_container}
__api_port=${__vc_api_port}
__api_tls=${__vc_api_tls}
Expand Down Expand Up @@ -754,6 +757,8 @@ validator-import() {
exit 1
;;
esac
else
echo "This client loads web3signer keys at startup, skipping registration via keymanager."
fi
echo
done < <(find "$__key_root_dir" -maxdepth "$__depth" -name '*keystore*.json')
Expand Down Expand Up @@ -784,6 +789,11 @@ validator-register() {
exit 1
fi

if [ "${W3S_NOREG:-false}" = "true" ]; then
echo "This client loads web3signer keys at startup, skipping registration via keymanager."
exit 0
fi

__api_path=eth/v1/keystores
__token=NIL
__vc_api_container=${__api_container}
Expand Down