Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo Update docker-entrypoint.sh #1987

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mdqst
Copy link

@mdqst mdqst commented Nov 15, 2024

Description:
This pull request addresses an issue with an unclear phrase in the bash script comments. The original comment reads:

# For want of something more amazing, let's just fail if git fails to pull this

The phrase "For want of something more amazing" is not incorrect from a technical perspective but sounds awkward and informal. A clearer, more appropriate version would be:

# For lack of something more sophisticated, let's just fail if git fails to pull this

Importance:
While the original phrase is understandable, it could lead to confusion or misinterpretation due to its informality. By adjusting the wording to something more conventional, we ensure better readability and clarity in the script, especially for future developers who might maintain or contribute to this project. This small change helps improve the professionalism of the code and ensures that the comment communicates the intent clearly.

Fix comment typo in bash script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant