Typo Update docker-entrypoint.sh #1987
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses an issue with an unclear phrase in the bash script comments. The original comment reads:
# For want of something more amazing, let's just fail if git fails to pull this
The phrase "For want of something more amazing" is not incorrect from a technical perspective but sounds awkward and informal. A clearer, more appropriate version would be:
# For lack of something more sophisticated, let's just fail if git fails to pull this
Importance:
While the original phrase is understandable, it could lead to confusion or misinterpretation due to its informality. By adjusting the wording to something more conventional, we ensure better readability and clarity in the script, especially for future developers who might maintain or contribute to this project. This small change helps improve the professionalism of the code and ensures that the comment communicates the intent clearly.